Skip to content

Conversation

ugpeter
Copy link
Contributor

@ugpeter ugpeter commented Nov 25, 2024

Proposed changes

Created the first version of the SingleStore documentation.

Merge timing

ASAP once approved

Related issues (optional)

None

@ugpeter ugpeter requested a review from a team as a code owner November 25, 2024 01:14
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@pwseg pwseg requested a review from tcgilbert November 26, 2024 18:40
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one thing to add for me

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@ugpeter
Copy link
Contributor Author

ugpeter commented Dec 6, 2024

Thanks so much for the feedback. I have accepted all code changes requested and believe this is good to go. @tcgilbert @forstisabella - Please feel free to merge this PR into the mainline. Thanks so much.

@tcgilbert
Copy link
Contributor

@forstisabella, you can include this in the next docs deployment.

@ugpeter, since the catalog metadata has been submitted, we’re ready to move the integration to Public Beta once the docs are live. If you’d prefer to wait for a specific date, please let me know. Otherwise, I’ll proceed with making the integration live.

@forstisabella forstisabella merged commit c3f4b79 into segmentio:develop Dec 10, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants