Skip to content

Update node docs #7368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 9, 2025
Merged

Update node docs #7368

merged 11 commits into from
Jan 9, 2025

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Jan 2, 2025

Update node docs

@silesky silesky requested a review from a team as a code owner January 2, 2025 17:59
@silesky silesky requested a review from stayseesong January 2, 2025 17:59
@silesky silesky changed the title update serverless info Update serverless info and a lot of other nod docs Jan 2, 2025
@silesky silesky changed the title Update serverless info and a lot of other nod docs Update node docs Jan 2, 2025
didiergarcia
didiergarcia previously approved these changes Jan 2, 2025
View reviewed changes
stayseesong
stayseesong requested changes Jan 6, 2025
View reviewed changes
src/connections/sources/catalog/libraries/server/node/index.md
The plugins you write can improve functionality, enrich data, and control the flow and delivery of events. From modifying event payloads to changing analytics functionality, plugins help to speed up the process of getting things done.
Non-critical plugins run through a timeline that executes in order of insertion based on the entry type. Segment has these five entry types of non-critical plugins:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silesky is there a reason why you deleted this before the table?

Copy link
Contributor Author

@silesky silesky Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I didn't delete the table? I updated the table to be accurate/relevant to nodejs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't say you deleted the table. I'm asking why you deleted line 406

Copy link
Contributor Author

@silesky silesky Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I misread! I thought the critical vs non critical category was more confusing that useful, and just added that information to the plug-in description of each plug-in type (i.e. Load errors can block the pipeline). This makes this table more like the analytics.js one

stayseesong
stayseesong requested changes Jan 8, 2025
View reviewed changes
@stayseesong stayseesong added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jan 8, 2025
@stayseesong stayseesong merged commit d4b481c into develop Jan 9, 2025
4 checks passed
@stayseesong stayseesong deleted the update-serverless-info branch January 9, 2025 17:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stayseesong stayseesong stayseesong approved these changes

@didiergarcia didiergarcia didiergarcia left review comments

Assignees

No one assigned

Labels

content-update updates to content that are not new features, includes grammar fixes, added notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@silesky @didiergarcia @stayseesong