Skip to content

Conversation

bansrav
Copy link
Contributor

@bansrav bansrav commented Jun 27, 2025

Proposed changes

Updating documentation based on questions asked in client calls

Merge timing

ASAP once approved

Related issues (optional)

@bansrav bansrav requested a review from a team as a code owner June 27, 2025 00:49
@bansrav bansrav requested a review from stayseesong June 27, 2025 00:49
@bansrav
Copy link
Contributor Author

bansrav commented Jun 27, 2025

@stayseesong , can you pleas review this PR?

@bansrav bansrav changed the title Updating documentation based on questions asked in client calls [Amazon Conversions API] Updating documentation based on questions asked in client calls Jun 27, 2025
@stayseesong stayseesong added the content-update updates to content that are not new features, includes grammar fixes, added notes label Jun 27, 2025
@bansrav
Copy link
Contributor Author

bansrav commented Jun 29, 2025

All the feedback have been incorporated. @stayseesong , can you please take a look again? Thanks!

@joe-ayoub-segment
Copy link
Contributor

hi @stayseesong I'm good with this change. Any chance it could be deployed as soon as possible once you are happy with is?

@bansrav
Copy link
Contributor Author

bansrav commented Jul 7, 2025

hi @stayseesong , can you please merge the CR if there are no more comments?

@stayseesong stayseesong merged commit d46a8f8 into segmentio:develop Jul 7, 2025
4 checks passed
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@stayseesong
Copy link
Contributor

@bansrav this will go out on our deploy on thursday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants