fix: handle profiles warehouse schemaName

[ybr]

Only send schemaName to API if it differs from the remote state

This prevents API failures when the schema name already exists in the warehouse. The Segment API fails if we send a schemaName that matches the current configuration, even though it should be a no-op

[deanhuynh]

Hi thanks for contributing! What error are you seeing here exactly? And do you have reproduction steps? I would like to check if this is something we can fix on the backend.

[ybr]

Hi thanks for contributing! What error are you seeing here exactly? And do you have reproduction steps? I would like to check if this is something we can fix on the backend.

Hello Dean,

Sure. I had a case opened with Segment Support 575344.

Anytime the Segment API is called to update a profiles warehouse with the schemaName field, it fails with the below error. Even if the schemaName is the one already set in Segment for the same profiles warehouse (which looks like a no-op to me).
The Segment provider sends this schemaName field whatever what, even if unspecified or in ignore_changes.

Reproduction steps:

1. create using terraform a segment_profiles_warehouse
2. make terraform to update it like by changing the secret to connect with the warehouse (in the settings of the resource)

Error :

│ 400 Bad Request
│ {
│ "errors": [
│ {
│ "type": "bad-request",
│ "message": "Could not validate schema name. Error: schema found in the warehouse. Please check and try again."
│ }
│ ]
│ }

This error appears anytime the profiles warehouse requires an update of any kind.

The real use case we had:

1. A space was setup with its profiles warehouse manually through the Segment UI
2. We want to terraform Segment resources, so we use import and segment_profiles_warehouse terraform instructions to have them imported and managed by Segment.

Same error as above. The import works fine, but the definition not being exactly the same between manually created Segment resource and how it is defined in terraform code, terraform tries to update it.

I have been investigating the behavior of the Segment API using curl, you can PATCH the profiles warehouse but as soon as you send the schemaName field, the API fails.

I have been told by the support it is not workable to change the API so I volunteered to create this PR.

Hope this helps.

[Copilot]

Pull Request Overview

This PR fixes a bug in profiles warehouse schema name handling to prevent API failures when the schema name already exists in the warehouse configuration. The Segment API fails when receiving a schema name that matches the current configuration, even though it should be a no-op.

• Implements conditional schema name sending based on state comparison
• Adds comprehensive test coverage for schema name handling scenarios
• Updates comments to follow proper formatting conventions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
internal/provider/profiles_warehouse_resource.go	Adds determineSchemaNameForUpdate function and modifies update logic to only send schema name when it differs from remote state
internal/provider/profiles_warehouse_resource_test.go	Adds new test function and unit tests to verify schema name handling behavior, plus minor comment formatting fixes

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The comment 'null pointer, not the actual value' is confusing and incorrect. This should clarify that nil means the schemaName should not be sent to the API, consistent with other test descriptions.

Suggested change

	expectedResult: nil, // null pointer, not the actual value
	expectedResult: nil, // should not send schemaName to API (prevents API failure)

[Copilot]

The comment 'unknown becomes null pointer' is misleading. This should clarify that nil means the schemaName should not be sent to the API, consistent with the function's behavior and other test descriptions.

Suggested change

	expectedResult: nil, // unknown becomes null pointer
	expectedResult: nil, // should not send schemaName to API (prevents API failure)

[deanhuynh]

Going to add a few changes after testing.

[deanhuynh]

I'm unable to reproduce the issue on my end so far. I set up a Postgres profiles warehouse and set the schemaName. Then I fired off an update request to change another field, while still sending in the same schemaName. It was successful. Can you send specific commands that caused it to fail? Is there a particular warehouse you were using? I want to ensure it all works on my end before merging.