Open
Conversation
|
+1 |
|
+1 Any chance this could get rebased and merged sometime |
|
I'm also +1 on this one. |
Contributor
|
I think this should be updated to remove the same check from the plugin hook. No need to do this during runtime too. |
Author
|
I have only left that to maintain compatibility. But I may as well remove it altogether. Specially if that is what is holding it from being merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an extra script to install supervisor so it doesn't have to happen on post-release. I have leaved the installation on post-release as well, just in case.
Also I have added an "attach" command to see the output from the installation as it may take a long time and may fail for a number of reasons like if you still have a "quantal" buildstep image.