Runs the Docker container commands in detached mode#33
Open
rsteckler wants to merge 1 commit intosehrope:masterfrom
Open
Runs the Docker container commands in detached mode#33rsteckler wants to merge 1 commit intosehrope:masterfrom
rsteckler wants to merge 1 commit intosehrope:masterfrom
Conversation
…t on it to finish
|
I have the same issue as in #32 - after updating to dokku 0.4.4 - it hangs on installing supervisord to the container. This patch provided by @rsteckler actually helps (thank you). |
|
Hi, I tried this and it worked perfectly as well! thanks! |
|
This is actually caused by a Docker bug: |
|
🙌 |
|
Is this an acceptable work-around? Should it be merged, right now this makes the plugin not so much recommended, restarting processes is more-a-less a basic function and I just burned by it ;( |
|
Works for me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my machine, this fixes #32. Conceptually, it makes sense to me even though I'm by no means a Docker expert. "run -d" returns immediately from Docker and provides the container ID. The next line waits until the container command exits.