Skip to content

fix(giga): order fee validation checks correctly#3017

Open
arajasek wants to merge 1 commit intomainfrom
asr/fee-validation-nonce
Open

fix(giga): order fee validation checks correctly#3017
arajasek wants to merge 1 commit intomainfrom
asr/fee-validation-nonce

Conversation

@arajasek
Copy link
Contributor

@arajasek arajasek commented Mar 4, 2026

Describe your changes and provide context

This PR improves and cleans up the validation performed by the Giga executor before running a tx:

  • Moves all validation into its own method
  • Bumps nonce if and only if the nonce is correct
    • Basically "if nonce is correct, it will get bumped, regardless of any other potential failures"
  • Orders the various validation checks to match v2, so that in the edge-case where multiple things fail, we respect v2's behaviour.

Testing performed to validate your change

@arajasek arajasek marked this pull request as draft March 4, 2026 16:14
@arajasek
Copy link
Contributor Author

arajasek commented Mar 4, 2026

Draft until tested on pacific today

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 11, 2026, 1:56 PM

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.31%. Comparing base (2bb2537) to head (9d42f69).

Files with missing lines Patch % Lines
app/app.go 0.00% 87 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
- Coverage   58.33%   58.31%   -0.02%     
==========================================
  Files        2079     2079              
  Lines      171885   171920      +35     
==========================================
- Hits       100268   100258      -10     
- Misses      62671    62725      +54     
+ Partials     8946     8937       -9     
Flag Coverage Δ
sei-chain-pr 48.27% <0.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 68.07% <0.00%> (-2.53%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arajasek arajasek force-pushed the asr/fee-validation-nonce branch 2 times, most recently from a2e7292 to 95eeb60 Compare March 4, 2026 18:33
@arajasek arajasek marked this pull request as ready for review March 4, 2026 20:39
@arajasek arajasek force-pushed the asr/fee-validation-nonce branch 4 times, most recently from d53d491 to afb4803 Compare March 9, 2026 14:46
@arajasek arajasek force-pushed the asr/fee-validation-nonce branch from afb4803 to 9d42f69 Compare March 11, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant