flatkv cache by cody-littley · Pull Request #3027 · sei-protocol/sei-chain

cody-littley · 2026-03-05T21:45:18Z

Describe your changes and provide context

Add a caching layer to FlatKV, more than doubling performance in cryptosim benchmarks.

Testing performed to validate your change

Unit tests, ran benchmark over several days.

github-actions · 2026-03-05T21:46:17Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Mar 11, 2026, 4:03 PM

sei-db/state_db/sc/flatkv/flatcache/cache_impl.go

sei-db/db_engine/pebbledb/pebblecache/cache_impl.go

sei-db/db_engine/pebbledb/pebblecache/read_scheduler.go

codecov · 2026-03-06T19:02:20Z

Codecov Report

❌ Patch coverage is 80.71121% with 179 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.09%. Comparing base (2bb2537) to head (c3f34b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sei-db/state_db/sc/flatkv/store_write.go	66.43%	28 Missing and 21 partials ⚠️
sei-db/state_db/sc/flatkv/config.go	62.71%	11 Missing and 11 partials ⚠️
sei-db/db_engine/pebbledb/db.go	71.21%	11 Missing and 8 partials ⚠️
sei-db/db_engine/pebbledb/pebblecache/shard.go	91.66%	15 Missing and 3 partials ⚠️
sei-db/state_db/sc/flatkv/store.go	65.38%	9 Missing and 9 partials ⚠️
sei-db/db_engine/pebbledb/pebble_metrics.go	0.00%	10 Missing ⚠️
sei-db/db_engine/pebbledb/pebbledb_config.go	47.36%	5 Missing and 5 partials ⚠️
...db/db_engine/pebbledb/pebblecache/cache_metrics.go	85.48%	8 Missing and 1 partial ⚠️
sei-db/state_db/sc/composite/store.go	28.57%	5 Missing ⚠️
sei-db/db_engine/pebbledb/batch.go	80.00%	2 Missing and 2 partials ⚠️
... and 6 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3027      +/-   ##
==========================================
- Coverage   58.33%   58.09%   -0.25%     
==========================================
  Files        2079     2094      +15     
  Lines      171885   173991    +2106     
==========================================
+ Hits       100268   101075     +807     
- Misses      62671    63922    +1251     
- Partials     8946     8994      +48

Flag	Coverage Δ
sei-chain-pr	`48.78% <80.71%> (?)`
sei-db	`70.41% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
sei-db/common/metrics/phase_timer.go	`74.46% <100.00%> (+0.55%)`	⬆️
sei-db/common/threading/adhoc_pool.go	`100.00% <100.00%> (ø)`
sei-db/common/threading/chan_utils.go	`100.00% <100.00%> (ø)`
sei-db/config/sc_config.go	`100.00% <ø> (ø)`
sei-db/db_engine/pebbledb/pebblecache/lru_queue.go	`100.00% <100.00%> (ø)`
...ei-db/db_engine/pebbledb/pebblecache/noop_cache.go	`100.00% <100.00%> (ø)`
sei-db/db_engine/pebbledb/pebbledb_test_config.go	`100.00% <100.00%> (ø)`
sei-db/state_db/sc/flatkv/flatkv_test_config.go	`100.00% <100.00%> (ø)`
sei-db/state_db/sc/flatkv/snapshot.go	`66.95% <100.00%> (+0.39%)`	⬆️
sei-db/state_db/sc/flatkv/store_lifecycle.go	`57.14% <100.00%> (+0.69%)`	⬆️
... and 17 more

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sei-db/db_engine/pebbledb/pebblecache/cache_impl.go

sei-db/db_engine/pebbledb/pebblecache/shard.go

sei-db/state_db/sc/flatkv/store_write.go

sei-db/common/utils/work_pool.go

sei-db/common/threading/fixed_pool.go

sei-db/common/threading/pool_impl.go

sei-db/state_db/sc/flatkv/store.go

+
+	coreCount := runtime.NumCPU()
+	readPoolSize := int(cfg.ReaderThreadsPerCore*float64(coreCount) + float64(cfg.ReaderConstantThreadCount))
+	miscPoolSize := int(cfg.MiscPoolThreadsPerCore*float64(coreCount) + float64(cfg.MiscConstantThreadCount))


sei-db/state_db/sc/flatkv/store.go

+
+	coreCount := runtime.NumCPU()
+	readPoolSize := int(cfg.ReaderThreadsPerCore*float64(coreCount) + float64(cfg.ReaderConstantThreadCount))
+	miscPoolSize := int(cfg.MiscPoolThreadsPerCore*float64(coreCount) + float64(cfg.MiscConstantThreadCount))


sei-db/state_db/sc/flatkv/store.go

+	ctx, cancel := context.WithCancel(ctx)
+
+	coreCount := runtime.NumCPU()
+	readPoolSize := int(cfg.ReaderThreadsPerCore*float64(coreCount) + float64(cfg.ReaderConstantThreadCount))


sei-db/state_db/sc/flatkv/store.go

+	ctx, cancel := context.WithCancel(ctx)
+
+	coreCount := runtime.NumCPU()
+	readPoolSize := int(cfg.ReaderThreadsPerCore*float64(coreCount) + float64(cfg.ReaderConstantThreadCount))


sei-db/state_db/sc/flatkv/store.go

 	"io"
 	"os"
 	"path/filepath"
+	"runtime"


sei-db/db_engine/pebbledb/pebblecache/shard.go

+		valueChan := entry.valueChan
+		s.lock.Unlock()
+		s.metrics.reportCacheMisses(1)
+		startTime := time.Now()


sei-db/db_engine/pebbledb/pebblecache/shard.go

+		entry.valueChan = valueChan
+		s.lock.Unlock()
+		s.metrics.reportCacheMisses(1)
+		startTime := time.Now()


sei-db/db_engine/pebbledb/pebblecache/shard.go

+	}
+
+	s.metrics.reportCacheMisses(int64(len(pending)))
+	startTime := time.Now()


sei-db/db_engine/pebbledb/pebblecache/shard.go

+	}
+
+	s.metrics.reportCacheMissLatency(time.Since(startTime))
+	go s.bulkInjectValues(pending)


sei-db/db_engine/pebbledb/pebblecache/cache_metrics.go

+		missLatency: missLatency,
+	}
+
+	go cm.collectLoop(ctx, scrapeInterval, getSize)


Cody Littley added 7 commits March 5, 2026 13:31

Created a cache for flatKV.

7c5e216

checkpoint

4a404ee

incremental progress

d36e825

address feedback

2ccbe62

more fixes

f412e85

bugfix

e310037

wire in cache

cf1071c

cody-littley self-assigned this Mar 5, 2026

cody-littley added the non-app-hash-breaking label Mar 5, 2026

github-advanced-security bot found potential problems Mar 5, 2026

View reviewed changes

sei-db/state_db/sc/flatkv/flatcache/cache_impl.go Fixed Show fixed Hide fixed

sei-db/db_engine/pebbledb/pebblecache/cache_impl.go Fixed Show fixed Hide fixed

sei-db/db_engine/pebbledb/pebblecache/read_scheduler.go Fixed Show fixed Hide fixed

Cody Littley added 9 commits March 6, 2026 09:21

Merge branch 'main' into cjl/flatkv-cache

11232ff

incremental improvements

a8c1c75

checkin

221d114

Moved where the cache sits

8eca079

bugfix

267feae

Batch update the cache

50b0be6

Add batch read to cache

2ca00d6

Add batch get to db interface

8f8534a

integrate batch reads

23c0277

github-advanced-security bot found potential problems Mar 6, 2026

View reviewed changes

Cody Littley added 2 commits March 6, 2026 13:18

wire in cache

02d3ca1

Introduce work pool, size caches differently

7ee1b08

github-advanced-security bot found potential problems Mar 6, 2026

View reviewed changes

sei-db/common/utils/work_pool.go Fixed Show fixed Hide fixed

sei-db/common/threading/fixed_pool.go Fixed Show fixed Hide fixed

sei-db/common/threading/pool_impl.go Fixed Show fixed Hide fixed

Cody Littley added 5 commits March 6, 2026 14:46

bugfix

20c70c3

Add unit constants

b714789

refactor threading utils

cc9d41d

cleanup

53b2bd8

Cleanup, fix race condition

c10e0cd

Cody Littley added 7 commits March 9, 2026 15:09

better error handling

a3f3907

use config to configure cache params

f255b87

Allow flatkv config to be set in tests

cf0a73d

tweak config

0b34737

incremental progress

452aa4d

move data dir into config

1c804a8

fix config file

663b2ea

github-advanced-security bot found potential problems Mar 10, 2026

View reviewed changes

Cody Littley added 5 commits March 10, 2026 10:36

cleanup

bb530b5

move pebble metrics to proper location

04daf75

clean up metrics

354818e

updated dashboard

b1574ac

fix histograms

07e071c

github-advanced-security bot found potential problems Mar 10, 2026

View reviewed changes

Cody Littley added 8 commits March 10, 2026 14:50

threading tests

d090796

test lru queue

dfd92c1

unit tests for shard

f751a9b

cache tests

7b5538e

moar unit tests

dc8d0c9

cleanup

e9cc9ca

Merge branch 'main' into cjl/flatkv-cache

c7a418c

Merge branch 'main' into cjl/flatkv-cache

087fd0f

cody-littley requested review from blindchaser and yzang2019 March 10, 2026 21:11

cody-littley marked this pull request as ready for review March 10, 2026 21:11

Cody Littley added 4 commits March 11, 2026 09:24

Merge branch 'main' into cjl/flatkv-cache

eb9bc51

unit test fixes

cea0ebb

fix hash bug

e58bec2

fixed path bug

c3f34b1

cody-littley marked this pull request as draft March 11, 2026 17:23

Conversation

cody-littley commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes and provide context

Testing performed to validate your change

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check warning

Check warning

Check warning

Check notice

Check notice

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cody-littley commented Mar 5, 2026 •

edited

Loading

github-actions bot commented Mar 5, 2026 •

edited

Loading

codecov bot commented Mar 6, 2026 •

edited

Loading