Open
Conversation
Remove all references of per struct logger instantiation, in favour of singual package level loggers. Remove now redundant logger interfaces and utilities across modules.
# Conflicts: # sei-cosmos/storev2/rootmulti/store.go # sei-db/state_db/bench/wrappers/db_implementations.go # sei-db/state_db/sc/composite/store_test.go # sei-db/state_db/sc/flatkv/lthash_correctness_test.go # sei-db/state_db/sc/flatkv/snapshot.go # sei-db/state_db/sc/flatkv/snapshot_test.go # sei-db/state_db/sc/flatkv/store.go # sei-db/state_db/sc/flatkv/store_test.go # sei-db/state_db/sc/flatkv/store_write_test.go
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3050 +/- ##
==========================================
- Coverage 58.36% 58.35% -0.01%
==========================================
Files 2079 2078 -1
Lines 171899 170821 -1078
==========================================
- Hits 100321 99677 -644
+ Misses 62637 62217 -420
+ Partials 8941 8927 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
arajasek
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all references of per struct logger instantiation, in favour of singular package level loggers.
Remove now redundant logger interfaces and utilities across modules.
Breaking changes to logging configuration:
--log-formatflag is deprecated. Log format is now configured exclusively via the SEI_LOG_FORMAT environment variable (values: "json", "text"). seilog captures the format once at process startup and shares a single handler across all loggers, avoiding an allocation per logger instantiation. Changing format at runtime is not supported by design.--log-levelflag still works but its priority has changed. The resolution order is now:Per-module level syntax ("consensus:debug,*:info") is no longer accepted by the CLI flag or env var; use seilog.SetLevel() with glob patterns ("tendermint/internal/consensus") instead. A follow up PR will introduce log level change at runtime via
seidcli command.Default log format changed from "plain" to "json" in DefaultBaseConfig. Operators relying on the previous plain-text
default must set SEI_LOG_FORMAT=text explicitly.