Skip to content

Conversation

@pandamouse
Copy link

@pandamouse pandamouse commented Feb 23, 2025

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
  • Link to original Github issue (if this is a bug-fix)
  • documentation updates to README file
  • examples within /tpl/index.tpl (for new options being added)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

- use trigger('focus') instead of focus()
- use typeof to check if option is a function instead of $.isFunction
Repository owner deleted a comment from fturiot Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant