Migrate to Rust 2021 edition #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change edition to 2021 - Increase MSRV to 1.56.0 - Remove `build.rs`, build-dependency on `autocfg`, and conditional compilation of methods requiring at least 1.56.0 - Update the CI matrix
This ports rust-lang/rust@1e2dba1e, part of rust-lang/rust#76492. `usize::BITS` was stabilized in Rust 1.53.0.
This change is ported from rust-lang/rust#91861. Also finish porting rust-lang/rust#84111, partially ported here in sekineh#34, by including the example of constructing a binary heap from an array.
This change was made in rust-lang/rust@857530ce, part of the transition of liballoc to the 2018 edition. Overlooked here in sekineh#34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37.
This migrates the crate to the Rust 2021 edition and increases the MSRV to 1.56.0, as discussed in #34.
Now that Rust 1.56.0 is required, we can remove
build.rsand the remaining uses of conditional compilation. We also port two more changes fromstdthat were not part of #34 because of version requirements:usize::BITSinstead of8 * std::mem::size_of::<usize>().Finally, while not exactly related to the edition migration, this PR includes a few other small fixes:
randto version 0.8.x.