Add new pre-commit hooks (#1543)

* add new hooks with fixes

* use clang-format inplace flag

* mess with formatting

* Revert "mess with formatting"

This reverts commit fda7c21.

* Remove unnecessary hooks

Author: egecetin

.pre-commit-config.yaml

@@ -10,11 +10,17 @@ repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.6.0
     hooks:
-      - id: trailing-whitespace
       - id: check-case-conflict
+      - id: check-executables-have-shebangs
+      - id: check-json
+      - id: check-shebang-scripts-are-executable
+      - id: check-merge-conflict
+      - id: check-symlinks
       - id: end-of-file-fixer
+      - id: forbid-submodules
       - id: mixed-line-ending
         args: ['--fix=lf']
+      - id: trailing-whitespace
   - repo: https://github.com/psf/black
     rev: 24.4.2
     hooks:
@@ -23,7 +29,7 @@ repos:
     rev: v1.3.5
     hooks:
       - id: clang-format
-        args: ["--style=file"]  # Use the .clang-format file for configuration
+        args: ["--style=file", "-i"]  # Use the .clang-format file for configuration and apply all fixes
         files: ^(Common\+\+|Packet\+\+|Pcap\+\+|Tests|Examples)/.*\.(cpp|h)$
       - id: cppcheck
         args: ["--std=c++11", "--language=c++", "--suppressions-list=cppcheckSuppressions.txt", "--inline-suppr", "--force"]
@@ -38,3 +44,7 @@ repos:
       - id: typos
         args: ['--config=typos-config.toml']
         pass_filenames: false
+  - repo: https://github.com/lovesegfault/beautysh
+    rev: v6.2.1
+    hooks:
+      - id: beautysh

Tests/Fuzzers/RegressionTests/run_tests.sh

@@ -1,10 +1,10 @@
 #!/bin/bash
 
 if [ -z "${SAMPLES}" ]; then
-SAMPLES=regression_samples
+    SAMPLES=regression_samples
 fi
 if [ -z "${BINARY}" ]; then
-BINARY=../Bin/FuzzTarget
+    BINARY=../Bin/FuzzTarget
 fi
 
 ERR_CODE=0
@@ -14,12 +14,12 @@ GREEN='\033[0;32m'
 NC='\033[0m'
 
 for sample in $(ls ${SAMPLES}); do
-	echo -n "Running sample $sample..."
-	"${BINARY}" "$SAMPLES/$sample" &> /dev/null && echo -e "${GREEN}[OK]${NC}" || { FAILED=True && echo -e "${RED}[FAIL]${NC}"; }
+    echo -n "Running sample $sample..."
+    "${BINARY}" "$SAMPLES/$sample" &> /dev/null && echo -e "${GREEN}[OK]${NC}" || { FAILED=True && echo -e "${RED}[FAIL]${NC}"; }
 done
 
 if [[ ! -z $FAILED ]]; then
-	ERR_CODE=1
+    ERR_CODE=1
 fi
 
 exit $ERR_CODE

Tests/Fuzzers/ossfuzz.sh

@@ -16,8 +16,7 @@ cmake -DPCAPPP_BUILD_FUZZERS=ON -DPCAPPP_BUILD_TESTS=OFF -DPCAPPP_BUILD_EXAMPLES
 cmake --build $TARGETS_DIR -j
 
 # Copy target and options
-FUZZERS="
-    FuzzTarget \
+FUZZERS="FuzzTarget \
     FuzzTargetNg \
     FuzzTargetSnoop \
     FuzzWriter \