Skip to content

Added overload to getAndDetach that accepts a constant reference. #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Added overload to getAndDetach that accepts a constant reference. #1512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55f33b
Added overload to getAndDetach that accepts a constant reference to a…
Dimi1010 Jul 26, 2024
0611eff
Merge branch 'dev' into fix/pv-detach-iterator
Dimi1010 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Common++/header/PointerVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,18 @@ namespace pcpp
return result;
}

/**
* Removes an element from the vector and transfers ownership to the returned unique pointer.
* @param[in] position An iterator pointing to the element to detach.
* @return An unique pointer that holds ownership of the detached element.
*/
std::unique_ptr<T> getAndDetach(VectorIterator const& position)
{
std::unique_ptr<T> result(*position);
m_Vector.erase(position);
return result;
}

/**
* Return a pointer to the element in a certain index
* @param[in] index The index to retrieve the element from
Expand Down