Reorder filter definitions. #1965
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split of #1957.
The PR reorders the filter definitions in the order
public / protected / private
, allowing external behaviour (public methods) to be at the top of the class for easy reference. Notable exception are constructors, which are placed at the top of the class.Additional changes:
getOperator
in the public API ofIFilterWithOperator
.getDir
asgetDirection
in the public API ofIFilterWithDirection
.