Skip to content

Conversation

Dimi1010
Copy link
Collaborator

@Dimi1010 Dimi1010 commented Sep 15, 2025

Split of #1957.

The PR reorders the filter definitions in the order public / protected / private, allowing external behaviour (public methods) to be at the top of the class for easy reference. Notable exception are constructors, which are placed at the top of the class.

Additional changes:

  • Exposed getOperator in the public API of IFilterWithOperator.
  • Exposed getDir as getDirection in the public API of IFilterWithDirection.

@Dimi1010 Dimi1010 changed the title Refactor/filter interface order Reorder filter definitions. Sep 15, 2025
@Dimi1010 Dimi1010 closed this Sep 15, 2025
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.50%. Comparing base (32384c2) to head (f7ac625).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1965      +/-   ##
==========================================
- Coverage   83.51%   83.50%   -0.01%     
==========================================
  Files         311      311              
  Lines       54897    54887      -10     
  Branches    12207    12207              
==========================================
- Hits        45845    45833      -12     
  Misses       7788     7788              
- Partials     1264     1266       +2     
Flag Coverage Δ
alpine320 75.96% <92.30%> (+<0.01%) ⬆️
fedora42 76.08% <92.30%> (-0.04%) ⬇️
macos-13 81.64% <90.47%> (-0.01%) ⬇️
macos-14 81.64% <90.47%> (-0.01%) ⬇️
macos-15 81.65% <90.47%> (-0.01%) ⬇️
mingw32 70.33% <69.23%> (-0.01%) ⬇️
mingw64 70.32% <69.23%> (+0.10%) ⬆️
npcap ?
rhel94 75.83% <92.30%> (-0.01%) ⬇️
ubuntu2004 60.26% <66.66%> (-0.01%) ⬇️
ubuntu2004-zstd 60.36% <66.66%> (-0.01%) ⬇️
ubuntu2204 75.74% <92.30%> (-0.01%) ⬇️
ubuntu2204-icpx 60.75% <80.95%> (-0.02%) ⬇️
ubuntu2404 75.99% <92.30%> (+<0.01%) ⬆️
ubuntu2404-arm64 75.61% <92.30%> (-0.02%) ⬇️
unittest 83.50% <100.00%> (-0.01%) ⬇️
windows-2022 85.50% <100.00%> (+0.14%) ⬆️
windows-2025 85.52% <100.00%> (+0.11%) ⬆️
winpcap 85.52% <100.00%> (-0.09%) ⬇️
xdp 53.55% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant