-
Notifications
You must be signed in to change notification settings - Fork 734
Improve parsing options support. #2042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dimi1010
wants to merge
9
commits into
seladb:dev
Choose a base branch
from
Dimi1010:feature/parse-options
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+340
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2042 +/- ##
==========================================
+ Coverage 83.11% 83.69% +0.58%
==========================================
Files 312 312
Lines 55381 55569 +188
Branches 11725 12007 +282
==========================================
+ Hits 46031 46511 +480
+ Misses 8424 7866 -558
- Partials 926 1192 +266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dimi1010
commented
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the parsing options by adding deferred parsing and incremental parsing.
The parsing procedure has been extracted from the
setRawDataprocedure and placed intoparsePacket.The new procedure can be called repeatedly on the same packet with different options and will incrementally parse the packet.
The packet parsing options have been grouped into the struct
ParseOptionsfor better method readability.The PR introduces new constructors and overloads to
PacketandsetRawPacketthat take the parse options structure or aNoParseTagif parsing is to be deferred.