Skip to content

Conversation

@Dimi1010
Copy link
Collaborator

@Dimi1010 Dimi1010 commented Jan 8, 2026

This PR improves the parsing options by adding deferred parsing and incremental parsing.

The parsing procedure has been extracted from the setRawData procedure and placed into parsePacket.
The new procedure can be called repeatedly on the same packet with different options and will incrementally parse the packet.

The packet parsing options have been grouped into the struct ParseOptions for better method readability.
The PR introduces new constructors and overloads to Packet and setRawPacket that take the parse options structure or a NoParseTag if parsing is to be deferred.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 92.15686% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.69%. Comparing base (44e9085) to head (00211fd).

Files with missing lines Patch % Lines
Packet++/src/Packet.cpp 87.50% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2042      +/-   ##
==========================================
+ Coverage   83.11%   83.69%   +0.58%     
==========================================
  Files         312      312              
  Lines       55381    55569     +188     
  Branches    11725    12007     +282     
==========================================
+ Hits        46031    46511     +480     
+ Misses       8424     7866     -558     
- Partials      926     1192     +266     
Flag Coverage Δ
alpine320 76.21% <86.59%> (?)
fedora42 75.98% <86.51%> (?)
macos-14 81.77% <89.62%> (+0.01%) ⬆️
macos-15 81.76% <89.23%> (+0.01%) ⬆️
mingw32 69.94% <79.03%> (-0.05%) ⬇️
mingw64 69.95% <79.03%> (+0.03%) ⬆️
npcap ?
rhel94 75.56% <86.51%> (?)
ubuntu2004 59.55% <69.60%> (?)
ubuntu2004-zstd 59.65% <69.60%> (?)
ubuntu2204 75.52% <86.51%> (?)
ubuntu2204-icpx 58.48% <81.48%> (+0.05%) ⬆️
ubuntu2404 75.87% <86.51%> (+3.32%) ⬆️
ubuntu2404-arm64 75.88% <86.31%> (?)
unittest 83.69% <92.15%> (+0.58%) ⬆️
windows-2022 85.51% <86.90%> (+0.09%) ⬆️
windows-2025 85.55% <86.90%> (+0.10%) ⬆️
winpcap 85.55% <86.90%> (-0.10%) ⬇️
xdp 52.19% <86.51%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dimi1010 Dimi1010 marked this pull request as ready for review January 17, 2026 18:45
@Dimi1010 Dimi1010 requested a review from seladb as a code owner January 17, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant