Skip to content

PHP8.4 support. PHP Deprecated: Implicitly marking parameter as nulla… #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odan merged 1 commit into from
May 27, 2025
Merged

PHP8.4 support. PHP Deprecated: Implicitly marking parameter as nulla… #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BasePathDetector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class BasePathDetector
* @param array<mixed> $server The SERVER data to use
* @param string|null $phpSapi The PHP_SAPI value
*/
public function __construct(array $server, string $phpSapi = null)
public function __construct(array $server, ?string $phpSapi = null)
{
$this->server = $server;
$this->phpSapi = $phpSapi ?? PHP_SAPI;
Expand Down
2 changes: 1 addition & 1 deletion src/BasePathMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* @var App The slim app
*/
private $app;

Check failure on line 19 in src/BasePathMiddleware.php

View workflow job for this annotation

GitHub Actions / PHP 8.1 Test on ubuntu-latest 

Property Selective\BasePath\BasePathMiddleware::$app with generic class Slim\App does not specify its types: TContainerInterface

Check failure on line 19 in src/BasePathMiddleware.php

View workflow job for this annotation

GitHub Actions / PHP 8.2 Test on ubuntu-latest 

Property Selective\BasePath\BasePathMiddleware::$app with generic class Slim\App does not specify its types: TContainerInterface

/**
* @var string|null
Expand All @@ -29,7 +29,7 @@
* @param App $app The slim app
* @param string|null $phpSapi The PHP_SAPI value
*/
public function __construct(App $app, string $phpSapi = null)
public function __construct(App $app, ?string $phpSapi = null)

Check failure on line 32 in src/BasePathMiddleware.php

View workflow job for this annotation

GitHub Actions / PHP 8.1 Test on ubuntu-latest 

Method Selective\BasePath\BasePathMiddleware::__construct() has parameter $app with generic class Slim\App but does not specify its types: TContainerInterface

Check failure on line 32 in src/BasePathMiddleware.php

View workflow job for this annotation

GitHub Actions / PHP 8.2 Test on ubuntu-latest 

Method Selective\BasePath\BasePathMiddleware::__construct() has parameter $app with generic class Slim\App but does not specify its types: TContainerInterface
{
$this->app = $app;
$this->phpSapi = $phpSapi;
Expand Down
Loading