Array reader code

[heinrichschiller]

Hello,

While looking through the different Selective libraries, I noticed that both selective/array-reader and selective/config contain identical code. That made me wonder if it wouldn’t be better for selective/config to wrap the functionality of selective/array-reader instead of maintaining duplicate code.

So, I refactored the code, and selective/array-reader is now used directly. Hopefully, this makes the code cleaner and easier to maintain. Its behavior should be exactly the same as before—at least it still passes the tests.

Is this useful for you, or should it just be discarded? I’ll leave that up to you. :)

Best regards,
Heinrich Schiller

[odan]

Hi @heinrichschiller Thanks for the PR. I totally see where you’re coming from, but I try to keep these two libraries completely separate, even if that means having some duplicated logic. It’s a bit more maintenance, but it keeps each package independent and easier to reason about on its own. But I really appreciate you taking the time to look into this! Thanks :-)