Skip to content

Commit f06dbce

Browse files
committed
Dashboard: Fix bug where "Skipped" tests had "Passed"
1 parent 9df9294 commit f06dbce

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10829,6 +10829,7 @@ def __create_log_path_as_needed(self, test_logpath):
1082910829
def __process_dashboard(self, has_exception, init=False):
1083010830
""" SeleniumBase Dashboard Processing """
1083110831
if self._multithreaded:
10832+
existing_res = sb_config._results # For recording "Skipped" tests
1083210833
abs_path = os.path.abspath(".")
1083310834
dash_json_loc = constants.Dashboard.DASH_JSON
1083410835
dash_jsonpath = os.path.join(abs_path, dash_json_loc)
@@ -10915,8 +10916,8 @@ def __process_dashboard(self, has_exception, init=False):
1091510916
sb_config.item_count_untested -= 1
1091610917
elif (
1091710918
self._multithreaded
10918-
and test_id in sb_config._results.keys()
10919-
and sb_config._results[test_id] == "Skipped"
10919+
and test_id in existing_res.keys()
10920+
and existing_res[test_id] == "Skipped"
1092010921
):
1092110922
sb_config._results[test_id] = "Skipped"
1092210923
sb_config.item_count_skipped += 1

0 commit comments

Comments
 (0)