Skip to content

Fix visual tests that use the "sb" fixture (and more!)
Compare
Choose a tag to compare
@mdmintz mdmintz released this 03 Dec 05:22
· 3594 commits to master since this release
v2.2.6
e8b8338
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Fix visual tests that use the "sb" fixture (and more!)

  • Fix log path issue with visual tests that use the sb fixture.
  • Handle a possible edge case with page loads.
  • Make sure highlighting isn't blocked by pop-up alerts.
  • Set WAIT_FOR_RSC_ON_CLICKS to be False by default.
    -- Tests will be faster, but you may need to manually call self.accept_alert() or self.dismiss_alert() because previously, waiting for the readyState of the page to be "complete" might have dismissed alerts automatically due to an existing WebDriver "feature" where calling self.execute_script("") automatically closes pop-up alerts.
Assets 2
Loading