Skip to content

Update settings.en.md#501

Closed
WDutra22 wants to merge 1 commit intoselfcustody:mainfrom
WDutra22:patch-1
Closed

Update settings.en.md#501
WDutra22 wants to merge 1 commit intoselfcustody:mainfrom
WDutra22:patch-1

Conversation

@WDutra22
Copy link

I just corrected broken links of images

What is this PR for?

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

I just corrected broken links of images
@qlrd
Copy link
Member

qlrd commented Feb 14, 2025

@WDutra22 Nice.

Since these PR changes documentation, i think it would be nice to have the 3 PRs in only one. Maybe a squash or cherry-pick them would work.

@odudex
Copy link
Member

odudex commented Feb 14, 2025

Casually, I'm refactoring docs for next release and a lot has changed on image names, as I increased their resolution.
Please use branch relative to PR #498 - tr_miniscript as reference.
@qlrd is right, you could do a single PR with all changes.
Please also note the en suffix on images cannot be hard coded, as documentation has multi-lingual support, and image suffix will change dynamically in case we add more languages, ex: ...pt.png, ...de.png, ...jp.png

@WDutra22 WDutra22 closed this Feb 14, 2025
@tadeubas
Copy link
Member

This PR MAY BROKE the links! Please, verify that the docs imgs are working fine when generated.

@WDutra22 WDutra22 deleted the patch-1 branch February 14, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants