Skip to content

GPG ECDSA secp256k1 Keys and Signatures#595

Draft
odudex wants to merge 1 commit intoselfcustody:developfrom
odudex:gpg_secp256k1
Draft

GPG ECDSA secp256k1 Keys and Signatures#595
odudex wants to merge 1 commit intoselfcustody:developfrom
odudex:gpg_secp256k1

Conversation

@odudex
Copy link
Member

@odudex odudex commented May 7, 2025

What is this PR for?

  • Add GPG ECDSA secp256k1 Keys and signatures as e BIP85 feature
  • Standardize navigation on BIP85 menu

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

Did you build the code and tested on device?

  • Yes - Amigo

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

❌ Patch coverage is 1.21951% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.63%. Comparing base (e6b895e) to head (db8c145).

Files with missing lines Patch % Lines
src/krux/pages/home_pages/gpg_ui.py 0.00% 73 Missing ⚠️
src/krux/pages/home_pages/bip85.py 11.11% 8 Missing ⚠️

❌ Your patch check has failed because the patch coverage (1.21%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #595      +/-   ##
===========================================
- Coverage    97.37%   96.63%   -0.75%     
===========================================
  Files           83       84       +1     
  Lines        10525    10607      +82     
===========================================
+ Hits         10249    10250       +1     
- Misses         276      357      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odudex odudex force-pushed the gpg_secp256k1 branch 2 times, most recently from 6180d55 to 8e565a8 Compare September 11, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant