fix: remove failTitle arg in findSRIssues call

[BinToss]

This extraneous argument caused "Error: Variable $owner of type String! was provided invalid value"

Fixes #1163

github/lib/find-sr-issues.js

Line 4 in ea6386d

export default async (octokit, logger, labels, owner, repo) => {

github/lib/fail.js

Lines 59 to 66 in ea6386d

	const [srIssue] = await findSRIssues(
	octokit,
	logger,
	failTitle,
	labels,
	owner,
	repo,
	);

---

In the mean time, users can use patch-package or yarn's patch command to patch the issue unofficially.

[BinToss]

I believe findSRIssues should be refactored to take a single object parameter to prevent this off-by-one issue from happening again. But that would entail breaking changes to the internal API.

[babblebey]

Good catch @BinToss

Wonder how that got there 🫣

Thanks.

[BinToss]

I wonder why Prettier is exiting with an error code.
The warning does not occur in the parent commit despite being stylistically identical. Is there a whitespace or invisible character change I'm not seeing?

Edit: ah. The function call line wrapping condition is no longer met.

diff --git a/lib/fail.js b/lib/fail.js
index 91b147d..2afe1e2 100644
--- a/lib/fail.js
+++ b/lib/fail.js
@@ -56,13 +56,7 @@ export default async function fail(pluginConfig, context, { Octokit }) {
     const body = failComment
       ? template(failComment)({ branch, errors })
       : getFailComment(branch, errors);
-    const [srIssue] = await findSRIssues(
-      octokit,
-      logger,
-      labels,
-      owner,
-      repo,
-    );
+    const [srIssue] = await findSRIssues(octokit, logger, labels, owner, repo);

     const canCommentOnOrCreateIssue = failCommentCondition
       ? template(failCommentCondition)({ ...context, issue: srIssue })

[travi]

thank you!

[github-actions]

🎉 This PR is included in version 12.0.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀