Address review feedback: remove variables, comment, and use ternary operators

Co-authored-by: fgreinacher <[email protected]>

Author: Copilot

lib/publish.js

@@ -56,35 +56,20 @@ export default async (pluginConfig, context) => {
   debug("milestones: %o", milestones);
 
   if (assets && assets.length > 0) {
-    // Apply template expansion to assets BEFORE globbing (original approach but moved before)
     const templatedAssets = assets.map((asset) => {
       if (isPlainObject(asset)) {
         const templatedAsset = { ...asset };
         if (asset.path) {
-          if (Array.isArray(asset.path)) {
-            templatedAsset.path = asset.path.map(pattern => template(pattern)(context));
-          } else {
-            templatedAsset.path = template(asset.path)(context);
-          }
-        }
-        if (asset.url) {
-          templatedAsset.url = template(asset.url)(context);
-        }
-        if (asset.label) {
-          templatedAsset.label = template(asset.label)(context);
-        }
-        if (asset.type) {
-          templatedAsset.type = template(asset.type)(context);
-        }
-        if (asset.filepath) {
-          templatedAsset.filepath = template(asset.filepath)(context);
-        }
-        if (asset.target) {
-          templatedAsset.target = template(asset.target)(context);
-        }
-        if (asset.status) {
-          templatedAsset.status = template(asset.status)(context);
+          templatedAsset.path = Array.isArray(asset.path) 
+            ? asset.path.map(pattern => template(pattern)(context))
+            : template(asset.path)(context);
         }
+        templatedAsset.url = asset.url ? template(asset.url)(context) : asset.url;
+        templatedAsset.label = asset.label ? template(asset.label)(context) : asset.label;
+        templatedAsset.type = asset.type ? template(asset.type)(context) : asset.type;
+        templatedAsset.filepath = asset.filepath ? template(asset.filepath)(context) : asset.filepath;
+        templatedAsset.target = asset.target ? template(asset.target)(context) : asset.target;
+        templatedAsset.status = asset.status ? template(asset.status)(context) : asset.status;
         return templatedAsset;
       } else if (Array.isArray(asset)) {
         // Handle array of glob patterns
@@ -109,16 +94,10 @@ export default async (pluginConfig, context) => {
     await Promise.all(
       allAssets.map(async (asset) => {
         const path = isPlainObject(asset) ? asset.path : asset;
-        const _url = asset.url;
-        const label = asset.label;
-        const type = asset.type;
-        const filepath = asset.filepath;
-        const target = asset.target;
-        const status = asset.status;
-
-        if (_url) {
-          assetsList.push({ label, rawUrl: _url, type, filepath });
-          debug("use link from release setting: %s", _url);
+
+        if (asset.url) {
+          assetsList.push({ label: asset.label, rawUrl: asset.url, type: asset.type, filepath: asset.filepath });
+          debug("use link from release setting: %s", asset.url);
         } else {
           const file = pathlib.resolve(cwd, path);
 
@@ -137,24 +116,24 @@ export default async (pluginConfig, context) => {
           }
 
           debug("file path: %o", path);
-          debug("file label: %o", label);
-          debug("file type: %o", type);
-          debug("file filepath: %o", filepath);
-          debug("file target: %o", target);
-          debug("file status: %o", status);
+          debug("file label: %o", asset.label);
+          debug("file type: %o", asset.type);
+          debug("file filepath: %o", asset.filepath);
+          debug("file target: %o", asset.target);
+          debug("file status: %o", asset.status);
 
           let uploadEndpoint;
           let response;
 
-          if (target === "generic_package") {
-            const finalLabel = label ?? pathlib.basename(file);
+          if (asset.target === "generic_package") {
+            const finalLabel = asset.label ?? pathlib.basename(file);
             // Upload generic packages
             const encodedLabel = encodeURIComponent(finalLabel);
             // https://docs.gitlab.com/ee/user/packages/generic_packages/#publish-a-package-file
             uploadEndpoint = urlJoin(
               projectApiUrl,
               `packages/generic/release/${encodedVersion}/${encodedLabel}?${
-                status ? `status=${status}&` : ""
+                asset.status ? `status=${asset.status}&` : ""
               }select=package_file`
             );
 
@@ -170,7 +149,7 @@ export default async (pluginConfig, context) => {
             // https://docs.gitlab.com/ee/user/packages/generic_packages/#download-package-file
             const url = urlJoin(projectApiUrl, `packages/generic/release/${encodedVersion}/${encodedLabel}`);
 
-            assetsList.push({ label: finalLabel, alt: "release", url, type: "package", filepath });
+            assetsList.push({ label: finalLabel, alt: "release", url, type: "package", filepath: asset.filepath });
 
             logger.log("Uploaded file: %s (%s)", url, response.file.url);
           } else {
@@ -191,7 +170,7 @@ export default async (pluginConfig, context) => {
             const { alt, full_path } = response;
             const url = urlJoin(gitlabUrl, full_path);
 
-            assetsList.push({ label, alt, url, type, filepath });
+            assetsList.push({ label: asset.label, alt, url, type: asset.type, filepath: asset.filepath });
 
             logger.log("Uploaded file: %s", url);
           }