Skip to content

fix: increase retry limit and make it configurable #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: increase retry limit and make it configurable #800

merged 2 commits into from
Dec 4, 2024

Conversation

@fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Dec 3, 2024 •
edited
Loading

Resolves #361

@fgreinacher fgreinacher requested a review from Copilot December 3, 2024 13:33
Copilot AI reviewed Dec 3, 2024
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 suggestion.

Files not reviewed (2)
  • README.md: Evaluated as low risk
  • lib/fail.js: Evaluated as low risk

@fgreinacher fgreinacher force-pushed the fix/retry-limit branch 2 times, most recently from ebd9daa to cd9ee44 Compare December 3, 2024 13:37
@fgreinacher
Copy link
Contributor Author

@JonasSchubert Could you have a look here? 🙇

Copilot AI reviewed Dec 3, 2024
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • README.md: Evaluated as low risk
  • lib/success.js: Evaluated as low risk

JonasSchubert
JonasSchubert approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@JonasSchubert JonasSchubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fgreinacher fgreinacher merged commit f1d3257 into master Dec 4, 2024
14 checks passed
@fgreinacher fgreinacher deleted the fix/retry-limit branch December 4, 2024 21:17
@github-actions
Copy link

github-actions bot commented Dec 4, 2024

🎉 This PR is included in version 13.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JonasSchubert JonasSchubert JonasSchubert approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Response code 429 (Too Many Requests) on successComment

3 participants

@fgreinacher @JonasSchubert