Skip to content

fix: add preferLocal option to allow execa to use local npm version #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 17, 2022
Merged

fix: add preferLocal option to allow execa to use local npm version #445

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b96046
fix: add `preferLocal` option to allow execa to use local npm version
antongolub Dec 23, 2021
81ad42a
Merge branch 'master' into prefer-local-npm
antongolub Dec 30, 2021
1b65098
Merge branch 'master' into prefer-local-npm
antongolub Jan 7, 2022
a912398
Merge branch 'beta' into prefer-local-npm
travi Jan 17, 2022
bb4d6f6
refactor: knocked-down execa options to resolve lint issue
travi Jan 17, 2022
087de5f
style: linting
antongolub Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/add-channel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ module.exports = async (npmrc, {npmPublish}, pkg, context) => {
{
cwd,
env,
preferLocal: true,
}
);
result.stdout.pipe(stdout, {end: false});
Expand Down
2 changes: 1 addition & 1 deletion lib/prepare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = async (npmrc, {tarballDir, pkgRoot}, {cwd, env, stdout, stderr,

if (tarballDir) {
logger.log('Creating npm package version %s', version);
const packResult = execa('npm', ['pack', basePath, '--userconfig', npmrc], {cwd, env});
const packResult = execa('npm', ['pack', basePath, '--userconfig', npmrc], {cwd, env, preferLocal: true});
packResult.stdout.pipe(stdout, {end: false});
packResult.stderr.pipe(stderr, {end: false});

Expand Down
2 changes: 1 addition & 1 deletion lib/publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = async (npmrc, {npmPublish, pkgRoot}, pkg, context) => {
const result = execa(
'npm',
['publish', basePath, '--userconfig', npmrc, '--tag', distTag, '--registry', registry],
{cwd, env}
{cwd, env, preferLocal: true}
);
result.stdout.pipe(stdout, {end: false});
result.stderr.pipe(stderr, {end: false});
Expand Down
2 changes: 1 addition & 1 deletion lib/verify-auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module.exports = async (npmrc, pkg, context) => {

if (normalizeUrl(registry) === normalizeUrl(DEFAULT_NPM_REGISTRY)) {
try {
const whoamiResult = execa('npm', ['whoami', '--userconfig', npmrc, '--registry', registry], {cwd, env});
const whoamiResult = execa('npm', ['whoami', '--userconfig', npmrc, '--registry', registry], {cwd, env, preferLocal: true});
whoamiResult.stdout.pipe(stdout, {end: false});
whoamiResult.stderr.pipe(stderr, {end: false});
await whoamiResult;
Expand Down