refactor(sources): restructure orcid.py to follow BaseSource pattern #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor orcid.py to match the architecture of base.py and core.py by implementing the BaseSource abstract class pattern. - Create ORCID class with fetch(), extract_hits(), map_hit(), search() methods - Add type hints and docstrings - Remove unused code (get_orcid_access_token, old_search) - Preserve module-level search() for backward compatibility All functionality preserved. No breaking changes.
I want to delete this file because it was committed unintentionally and was not ignored by .gitignore
huntila
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ORCID Source Module to BaseSource Pattern
Summary
Refactor
sources/orcid.pyto follow theBaseSourcearchitecture patternChanges
ORCIDclass inheriting fromBaseSourcefetch(),extract_hits(),map_hit(),search()methodsget_orcid_access_token(),old_search())search()for backward compatibilityFunctionality
All existing functionality preserved - no breaking changes.
Testing
Verify ORCID search returns
Authorobjects inresults['researchers']with expected fields populated.