refactor: transport selection logic #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultraviolet10
commented
Jul 17, 2025
vplasencia
approved these changes
Jul 17, 2025
Member
vplasencia
left a comment
vplasencia
left a comment
There was a problem hiding this comment.
Great work! Thank you so much! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the transport selection logic in the SemaphoreViem constructor.
The new implementation uses a standard if/else block to select the appropriate transport based on the provided options and network input.
Type of change: Refactor (code quality improvement, no functional changes)
Current behavior: Transport selection used a nested ternary, which was less readable and not lint-compliant.
New behavior: Uses a clear if/else block for transport selection, resolving the lint warning and improving code clarity.
Breaking change: No breaking changes; the logic and API remain the same.
Related Issue(s)
#1005
Other information
The new implementation is functionally equivalent to the previous one.
No changes to the public API or user-facing behavior.
No new warnings or errors are generated.
All tests pass locally.
Checklist
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have run yarn format and yarn lint without getting any errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes