Skip to content

Conversation

@vplasencia
Copy link
Member

@vplasencia vplasencia commented Jul 22, 2025

Description

This PR adds the zk artifacts generated from the staging trusted setup performed with P0tion. The changes include:

  • Modify Solidity version in smart contracts from >=0.8.23 <=0.8.28 to >=0.8.23 <0.9.0.
  • Update VK_POINT_BYTES in contracts with the new values.
  • Update @zk-kit/artifacts version from 1.8.0 to 2.0.1.
  • Update @zk-kit/semaphore-artifacts version in the artifacts in the proof package from 4.0.0 to 4.13.0-beta.0.
  • Update the proof package accordingly to use merkleProofIndex instead of merkleProofIndices.

Staging Trusted Setup Ceremony: https://pse-p0tion-staging.web.app/projects/Semaphore%20Binary%20Merkle%20Root%20Fix

Related Issue(s)

Re #999

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Important

We do not accept pull requests for minor grammatical fixes (e.g., correcting typos, rewording sentences) or for fixing broken links, unless they significantly improve clarity or functionality. These contributions, while appreciated, are not a priority for merging. If you notice any of these issues, please create a GitHub Issue to report them so they can be properly tracked and addressed.

@vplasencia vplasencia requested a review from a team as a code owner July 22, 2025 18:50
@openzeppelin-code
Copy link

refactor: update the proof package and smart contracts

Generated at commit: 891571baa1a25f14eddc75006fca79e17f8dee8c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
5
15
20
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vplasencia vplasencia merged commit 4905353 into fix/under-constrained-bug-binary-merkle-root Jul 22, 2025
4 checks passed
@vplasencia vplasencia deleted the feat/update-proof-package-and-contracts branch July 22, 2025 19:35
vplasencia added a commit that referenced this pull request Jul 22, 2025
* Fix/update binary merkle root circuit version (#1000)

* fix(circuits)!: update binary merkle root circuit version

re #999

* chore: update snarkjs version from 0.7.4 to 0.7.5

* refactor: update the proof package and smart contracts  (#1011)

refactor: update the proof package and smart contracts with new zk artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants