Skip to content

fix: include solhint config file in contracts templates #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vplasencia merged 1 commit into from
Dec 18, 2024
Merged

fix: include solhint config file in contracts templates #929

vplasencia merged 1 commit into from
Dec 18, 2024

Conversation

@vplasencia
Copy link
Member

@vplasencia vplasencia commented Dec 18, 2024

Description

This PR includes the .solhint.json config file in contracts templates.

Related Issue(s)

Closes #928

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vplasencia vplasencia requested a review from a team as a code owner December 18, 2024 11:08
@vplasencia vplasencia merged commit f77df8d into main Dec 18, 2024
5 checks passed
@vplasencia vplasencia deleted the fix/publish-solhint-config-contract-templates branch December 18, 2024 12:01
FaezehShakouri pushed a commit to FaezehShakouri/semaphore that referenced this pull request Feb 1, 2025
@vplasencia
fix: include solhint config file in contracts templates (semaphore-pr…
6174149 
…otocol#929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Solhint config file is not included in contracts templates

2 participants

@vplasencia