Skip to content

fix: clean node_modules before build contracts #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dozie2001 wants to merge 15 commits into from
Closed

fix: clean node_modules before build contracts #934

Dozie2001 wants to merge 15 commits into from

Conversation

@Dozie2001
Copy link
Contributor

@Dozie2001 Dozie2001 commented Dec 22, 2024

Description

Related Issue(s)

Close #915

Other information

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Dozie2001 Dozie2001 requested a review from a team as a code owner December 22, 2024 13:20
@Dozie2001
Copy link
Contributor Author

Dozie2001 commented Jan 9, 2025

@cedoor still waiting on a review

@vplasencia
Copy link
Member

vplasencia commented Jan 9, 2025

Hey @Dozie2001! Thank you for this PR. I will review it asap.

vplasencia and others added 9 commits January 14, 2025 15:10
@vplasencia
docs: update contributing and pull_request_template files
abfcf9f
@0xpanoramix
feat(website): add obscurus to projects section (semaphore-protocol#941)
8b91d75 
re semaphore-protocol#939
@hanghuge
chore: fix 404 status URL (semaphore-protocol#917)
c2dce43 
Signed-off-by: hanghuge <[email protected]>
@vplasencia
docs(website): update roadmap (semaphore-protocol#943)
6e2ef75 
docs(website): update roadmap on the website
@vplasencia
docs: make year update dynamically on website and docs (semaphore-pro…
0f4aca3 
…tocol#945)

* docs: make year update dynamically on website and docs

* docs(docs): make year update dynamically
@youyyytrok
docs: fix broken link and typo correction (semaphore-protocol#923)
ed8141e 
* broken redirect CONTRIBUTING.md

* typo README.md
@sumitvekariya
docs: fixed circuit logic url (semaphore-protocol#931)
0ca80ca 
fix: circuit logic url
@vplasencia
chore(subgraph): update matchstick-as dependency (semaphore-protocol#946
4df7693 
)

* chore(subgraph): update matchstick-as dependency

* chore(subgraph): update dependency versions

* ci: update pull request workflow to install libssl1.1 before testing the subgraph

* ci: update pull requests workflow

* ci: update ubuntu version

* ci: update ubuntu version in tests

* ci: update ubuntu version
@zanastas @vplasencia
Add new article (semaphore-protocol#918)
e530412 
* Add new article

* Update apps/website/src/data/articles.json

remove referral link

Co-authored-by: Vivian Plasencia <[email protected]>

---------

Co-authored-by: Vivian Plasencia <[email protected]>
vplasencia
vplasencia requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dozie2001! Thank you for this PR. The branch has some conflicts because the subgraph dependencies were updated recently.

It looks like with the new version of the packages in the subgraph app, this issue and the one that was solved in this PR: #884 are not issues anymore.

It means that the changes added to this PR are no longer necessary.

What about updating this branch with the main branch changes (solving the conflicts) and undo the changes of this PR: https://github.com/semaphore-protocol/semaphore/pull/884/files in your PR?

@Dozie2001
Copy link
Contributor Author

Dozie2001 commented Feb 1, 2025

Will do

@Dozie2001 Dozie2001 closed this Feb 2, 2025
@openzeppelin-code
Copy link

openzeppelin-code bot commented Feb 2, 2025

fix: clean node_modules before build contracts

Generated at commit: 9831fd98c1dadbbdde7e52c4a5c5e098517d6f39

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
0
0
4
15
19
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@vplasencia vplasencia mentioned this pull request Feb 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplasencia vplasencia vplasencia requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error when running yarn codegen <network> after running yarn build inside the subgraph app

7 participants

@Dozie2001 @vplasencia @0xpanoramix @hanghuge @youyyytrok @sumitvekariya @zanastas