Skip to content

Comments

fix(data): fix semaphore viem class#985

Merged
vplasencia merged 1 commit intomainfrom
fix/semaphore-viem
May 21, 2025
Merged

fix(data): fix semaphore viem class#985
vplasencia merged 1 commit intomainfrom
fix/semaphore-viem

Conversation

@vplasencia
Copy link
Member

Description

This PR:

  • Fixes some bugs in the SemaphoreViem class.
  • Updates the Readme file docs
  • Adds tests for the bug fixes
  • Adds 100% test coverage for the SemaphoreViem class

Related Issue(s)

Closes #984

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

@vplasencia vplasencia requested a review from a team as a code owner May 21, 2025 14:40
@vplasencia vplasencia merged commit 6bc415f into main May 21, 2025
5 checks passed
@vplasencia vplasencia deleted the fix/semaphore-viem branch May 21, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix SemaphoreViem bugs

1 participant