Skip to content

Commit 33cb72f

Browse files
fix(front): URL encode branch name in case in contains '&' or '?' character (#458)
## 📝 Description renderedtext/project-tasks#2660 ## ✅ Checklist - [x] I have tested this change - [x] ~This change requires documentation update~
1 parent 26c99e9 commit 33cb72f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

front/assets/js/blocked.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ export var Blocked = {
112112
},
113113

114114
afterBuildHandler(branch, workflowId, checkUrl) {
115-
var query = [`branch=${branch}`, `workflow_id=${workflowId}`].join("&")
115+
var query = [`branch=${encodeURIComponent(branch)}`, `workflow_id=${encodeURIComponent(workflowId)}`].join("&")
116116
var url = checkUrl + "?" + query
117117

118118
console.log(`Checking workflows ${url}`)

front/assets/js/template_picker.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ export var TemplatePicker = {
155155
},
156156

157157
afterCommitHandler: function(branch, commitSha, workflowTip, projectName) {
158-
var query = [`branch=${branch}`, `commit_sha=${commitSha}`].join("&")
158+
var query = [`branch=${encodeURIComponent(branch)}`, `commit_sha=${encodeURIComponent(commitSha)}`].join("&")
159159
var url = "check_workflow?" + query
160160

161161
console.log(`Checking workflows ${url}`)

front/assets/js/workflow_editor/components/commit_panel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ export class CommitPanel {
223223
}
224224

225225
afterCommitHandler(branch, commitSha) {
226-
var query = [`branch=${branch}`, `commit_sha=${commitSha}`].join("&")
226+
var query = [`branch=${encodeURIComponent(branch)}`, `commit_sha=${encodeURIComponent(commitSha)}`].join("&")
227227
var url = this.paths.checkWorkflow + "?" + query
228228

229229
console.log(`Checking workflows ${url}`)

0 commit comments

Comments
 (0)