Skip to content

Commit 8110a6c

Browse files
authored
fix(front): constructing flaky test branches list (#75)
## Description Constructing a list of branches in flaky test notifications breaks when no branches are specified. ## Type of Change <!-- Mark relevant items with an [x] --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation/Repository docs update - [ ] Performance improvement - [ ] Code refactoring - [ ] Test updates ## Testing <!-- How has this been tested? --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [x] Manual testing performed - [ ] Not applicable ## Documentation <!-- Mark relevant items with an [x] --> - [ ] Documentation update required - [ ] Changelog update required
1 parent aae0bae commit 8110a6c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

front/assets/js/flaky_tests/components/notification.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,8 @@ export const Notification = (props: NotificationProps) => {
233233
}
234234
};
235235

236+
const branches = settings?.branches?.join(`, `);
237+
236238
return (
237239
<Fragment>
238240
<div>
@@ -310,7 +312,7 @@ export const Notification = (props: NotificationProps) => {
310312
type="text"
311313
className="form-control w-100"
312314
placeholder="e.g. master,prod-*,.*"
313-
value={settings?.branches.join(` `)}
315+
value={branches}
314316
onInput={onBranchesChange}
315317
/>
316318
<p className="f6 mt1 mb0 nb1">

0 commit comments

Comments
 (0)