Implement and test list endpoint

Author: VeljkoMaksimovic

ee/ephemeral_environments/lib/ephemeral_environments/grpc/ephemeral_environments_server.ex

@@ -16,8 +16,14 @@ defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServer do
     CordonResponse
   }
 
-  def list(_request, _stream) do
-    %ListResponse{}
+  def list(request, _stream) do
+    case EphemeralEnvironments.Service.EphemeralEnvironmentType.list(request.org_id) do
+      {:ok, environment_types} ->
+        %{environment_types: environment_types}
+
+      {:error, error_message} ->
+        raise GRPC.RPCError, status: :unknown, message: error_message
+    end
   end
 
   def describe(_request, _stream) do

ee/ephemeral_environments/lib/ephemeral_environments/service/ephemeral_environment_type.ex

@@ -1,18 +1,37 @@
 defmodule EphemeralEnvironments.Service.EphemeralEnvironmentType do
+  import Ecto.Query
   alias EphemeralEnvironments.Repo
   alias EphemeralEnvironments.Repo.EphemeralEnvironmentType, as: Schema
 
+  @doc """
+  Lists all ephemeral environment types for a given organization.
+
+  ## Parameters
+    - org_id: String UUID of the organization
+
+  ## Returns
+    - {:ok, list of maps} on success
+  """
+  def list(org_id) when is_binary(org_id) do
+    environment_types =
+      Schema
+      |> where([e], e.org_id == ^org_id)
+      |> Repo.all()
+      |> Enum.map(&struct_to_map/1)
+
+    {:ok, environment_types}
+  end
+
   @doc """
   Creates a new ephemeral environment type.
 
   ## Parameters
     - attrs: Map with keys:
       - org_id (required)
       - name (required)
+      - max_number_of_instances (required)
       - created_by (required)
-      - state (optional, defaults to :draft)
       - description (optional)
-      - max_number_of_instances (optional)
 
   ## Returns
     - {:ok, map} on success

ee/ephemeral_environments/test/grpc/ephemeral_environments_server_test.exs

@@ -7,7 +7,8 @@ defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServerTest do
   alias InternalApi.EphemeralEnvironments.{
     CreateRequest,
     EphemeralEnvironmentType,
-    EphemeralEnvironments
+    EphemeralEnvironments,
+    ListRequest
   }
 
   @org_id Ecto.UUID.generate()
@@ -26,6 +27,58 @@ defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServerTest do
   end
 
   describe "list/2" do
+    test "returns empty list when no environment types exist", %{channel: channel} do
+      request = %ListRequest{org_id: @org_id}
+      {:ok, response} = EphemeralEnvironments.Stub.list(channel, request)
+      assert response.environment_types == []
+    end
+
+    test "returns all environment types for a specific org", %{channel: channel} do
+      # Create environment types for the test org
+      {:ok, env1} =
+        Support.Factories.EphemeralEnvironmentsType.insert(org_id: @org_id, name: "Development")
+
+      {:ok, env1} =
+        Support.Factories.EphemeralEnvironmentsType.insert(org_id: @org_id, name: "Staging")
+
+      # Create environment type for a different org (should not be returned)
+      {:ok, _} = Support.Factories.EphemeralEnvironmentsType.insert(org_id: Ecto.UUID.generate())
+
+      request = %ListRequest{org_id: @org_id}
+      {:ok, response} = EphemeralEnvironments.Stub.list(channel, request)
+
+      assert length(response.environment_types) == 2
+
+      dev_env = Enum.find(response.environment_types, &(&1.name == "Development"))
+      assert dev_env.org_id == @org_id
+      assert dev_env.name == "Development"
+
+      staging_env = Enum.find(response.environment_types, &(&1.name == "Staging"))
+      assert staging_env.org_id == @org_id
+      assert staging_env.name == "Staging"
+    end
+
+    test "handles multiple orgs correctly", %{channel: channel} do
+      org2_id = Ecto.UUID.generate()
+
+      {:ok, _} = Support.Factories.EphemeralEnvironmentsType.insert(org_id: @org_id)
+      {:ok, _} = Support.Factories.EphemeralEnvironmentsType.insert(org_id: @org_id)
+
+      # Create environment types for org2
+      {:ok, _} = Support.Factories.EphemeralEnvironmentsType.insert(org_id: org2_id)
+
+      # Request for org1
+      request1 = %ListRequest{org_id: @org_id}
+      {:ok, response1} = EphemeralEnvironments.Stub.list(channel, request1)
+      assert length(response1.environment_types) == 2
+      assert Enum.all?(response1.environment_types, &(&1.org_id == @org_id))
+
+      # Request for org2
+      request2 = %ListRequest{org_id: org2_id}
+      {:ok, response2} = EphemeralEnvironments.Stub.list(channel, request2)
+      assert length(response2.environment_types) == 1
+      assert Enum.all?(response2.environment_types, &(&1.org_id == org2_id))
+    end
   end
 
   describe "describe/2" do