fix(be): bugs founded by cursor #3195
Open
+90
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on August 10, 2025
Learn more in the Cursor dashboard.
| serverName = serverName[:i] | ||
| } | ||
| l, err = ldap.DialTLS("tcp", util.Config.LdapServer, &tls.Config{ // #nosec G402 - explicit secure config | ||
| ServerName: serverName, |
There was a problem hiding this comment.
Bug: LDAP TLS ServerName Extraction Fails
The TLS ServerName for LDAP connections is incorrectly extracted from LdapServer by trimming the port using strings.LastIndex(":"). This fails for bracketed IPv6 addresses, leaving brackets in the ServerName. The resulting invalid ServerName causes TLS SNI/hostname verification to fail, preventing successful LDAP logins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.