Conversation
✅ Don't forget to add
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 0e90820 |
| 🔍 Latest deploy log | https://app.netlify.com/projects/semgrep-docs-prod/deploys/686288fc02d414000885d047 |
| 😎 Deploy Preview | https://deploy-preview-2216--semgrep-docs-prod.netlify.app |
| 📱 Preview on mobile |
To edit notification comments on pull requests, go to your Netlify project configuration.
armchairlinguist
left a comment
There was a problem hiding this comment.
This pretty much looks good to me, so I'm going to approve.
I do have one suggestion, though: since we're calling a bit more attention to the use of tokens, I think we should also have a comment that we recommend having the token in the SCM config in the platform unless there's a specific reason that it's better to provide it via the broker.
As far as I understand this aligns with our usual recommendations (although @zyannes can correct me if I'm wrong, as well). Totally viable to consider that in a follow-up PR too since it can be done separately.
|
Yes I agree with @armchairlinguist. The preferred method is to store the created token in the SCM config instead of the broker. |
This PR:
Please ensure