-
Notifications
You must be signed in to change notification settings - Fork 108
Update triage-remediation.md #2467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update from Go to JavaScript, add Gitlab, do some small cleanup
✅ Deploy Preview for semgrep-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Context for this PR is some feedback from Alexis: https://semgrepinc.slack.com/archives/C0370TA46PL/p1768606113247099 |
khorne3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits; otherwise, LGTM
| ### Supported SCMs | ||
|
|
||
| - GitHub Cloud | ||
| - Gitlab Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Gitlab Cloud | |
| - GitLab Cloud |
| - The **private** GitHub app for Semgrep installed. | ||
| - The app must have [**Read and write** access on the **Contents** permission](#grant-read-and-write-access-to-a-private-github-semgrep-app). | ||
| - Optionally: if you have [a private registry, connect it to Semgrep](#connect-a-private-registry-to-semgrep). Currently, Semgrep supports only private Python registries. | ||
| - The app must have [**Read and write** access on the **Contents** permission](#grant-read-and-write-access-to-a-private-github-semgrep-app) which current customers may need to manually enable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - The app must have [**Read and write** access on the **Contents** permission](#grant-read-and-write-access-to-a-private-github-semgrep-app) which current customers may need to manually enable. | |
| - The app must have [**Read and write** access on the **Contents** permission](#grant-read-and-write-access-to-a-private-github-semgrep-app). If you're a current customer, you must manually enable this if you haven't already. |
Update from Go to JavaScript, add Gitlab, do some small cleanup
Thanks for improving Semgrep Docs 😀
Please ensure
Adding a new documentation page? Click to expand the checklist
.mdor.mdxfile in/docs/[section]/with frontmatter:slug,title,description,displayed_sidebar,tags/sidebars.js(shows in side nav)/src/theme/Navbar/Content/index.tsx→ add path togetCurrentSection()(highlights top nav)Sidebars fields for
displayed_sidebar:scanSidebar|rulewritingSidebar|devSidebar|learnSidebar|aboutSidebar|kbSidebar|whatsSemgrepSidebarTop nav fields for
getCurrentSection():'scan'|'write-rules'|'learning-guides'|'help'|'explore'