chore(sca-rpc): add internal dependency type#345
Merged
Conversation
aryx
approved these changes
Feb 7, 2025
b362c2b to
b8aaedd
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
|
Backwards compatibility summary: |
aryx
approved these changes
Feb 11, 2025
b8aaedd to
c70701f
Compare
c70701f to
9056434
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We need a different type to represent a dependency graph that is internal to
the Semgrep CLI. We already have these types in Python and in Ocaml. This adds
a corresponding type to the ATD interface so that the internal dependency type
can be sent via RPC.
I ran
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)I made sure we're still backward compatible with old versions of the CLI.
For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
Towards SC-2082.