Draft
Conversation
Collaborator
Author
|
The tests seem to be freezing randomly on some files. Here are some manual runs of the tests on Windows and they seem to be freezing on different files in different runs. @ajbt200128 @brandonspark would you have any ideas on how to debug or work around these freezes? |
shonfeder
approved these changes
May 13, 2025
Collaborator
Author
|
The Windows CI on the PR itself seems to have run cleanly. (on a rebuild) Freezes on these runs: |
punchagan
force-pushed
the
punchagan/win-tests
branch
from
0033378 to
395ecec
Compare
Run native tests in Windows CI. Also, we no longer depend on the Linux tests for cached results to use in the tests.
punchagan
force-pushed
the
punchagan/win-tests
branch
3 times, most recently
from
9c2fcd5 to
5f15514
Compare
Collaborator
Author
|
I added a commit to close the active editor tab after running the test and this reduces some of the flakiness of the tests on Windows, even though it doesn't completely fix it. |
punchagan
force-pushed
the
punchagan/win-tests
branch
2 times, most recently
from
00e395f to
73177d5
Compare
punchagan
force-pushed
the
punchagan/win-tests
branch
5 times, most recently
from
cb27bbe to
f98ab53
Compare
punchagan
force-pushed
the
punchagan/win-tests
branch
from
f98ab53 to
3d00025
Compare
To reduce flakiness of the tests, we close the editor tab once the tests for a specific file have been run. This seems to reduce the flakiness of the tests and help slightly with the freezes on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run native tests in Windows CI. Also, we no longer depend on the Linux
tests for cached results to use in the tests.
PR checklist: