Skip to content

Conversation

@Jleon13
Copy link

@Jleon13 Jleon13 commented Dec 2, 2024

Description

Provide a detailed description of your changes and why they are necessary.

Checklist

Ensure your pull request meets the following requirements:

  • I have reviewed existing notebooks to avoid duplications.
  • My notebook is fully executed.
  • I have included a list of all libraries and their versions used in the notebook.
  • The notebook file is named clearly to reflect the topic (e.g., cross-entropy-loss.ipynb).
  • I have placed the notebook in the appropriate directory under notebooks/.
  • My code is simple, precise, and adheres to good coding practices.

Linked Issues

List any related issues this pull request addresses.
e.g., "Fixes #123"

Additional Information

Any other information you want to include?
Include any other context, screenshots, or details that might help understand your changes.

Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook name must be in lower case. The versions of some libraries are also missing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although torchinfo is installed and the call torchsummary is also done, they are never used, I suggest to remove them if they are not going to be used or use summary of torchinfo to see the model modules as in vit

image

@jorge1b3 jorge1b3 marked this pull request as draft March 8, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants