feat: allow manager to interact with different rav and receipt #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/generic-manager
branch
from
28baab5 to
6885d9c
Compare
Pull Request Test Coverage Report for Build 12915395703Details
💛 - Coveralls |
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/generic-manager
branch
2 times, most recently
from
54a065d to
07fa2d8
Compare
refactor: remove unused escrow handler Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/generic-manager
branch
from
9ad810d to
44f0afa
Compare
gusinacio
commented
Jan 22, 2025
|
|
||
| [dependencies] | ||
| tap_core = { path = "../tap_core", version = "2.0.0" } | ||
| tap_core = { path = "../tap_core", version = "2.0.0", features = ["test"] } |
Contributor
Author
There was a problem hiding this comment.
Not really liking this feature here in tap_aggregator
Contributor
There was a problem hiding this comment.
Yeah... Why is it required?
| use criterion::{black_box, criterion_group, criterion_main, Criterion}; | ||
| use tap_core::{ | ||
| rav::ReceiptAggregateVoucher, receipt::Receipt, signed_message::EIP712SignedMessage, | ||
| rav::{Aggregate, ReceiptAggregateVoucher}, |
Contributor
There was a problem hiding this comment.
Are these benchmarks used?
Comment on lines
-41
to
+42
| received_rav: ReceiptAggregateVoucher, | ||
| expected_rav: ReceiptAggregateVoucher, | ||
| received_rav: String, | ||
| expected_rav: String, |
Contributor
There was a problem hiding this comment.
This seems strange! This is to allow for basically any generic message? Why not use a newtype?
| }, | ||
|
|
||
| /// Error when the received RAV does not match the expected RAV | ||
| #[error("Received RAV does not match expexted RAV")] |
Contributor
There was a problem hiding this comment.
Suggested change
| #[error("Received RAV does not match expexted RAV")] | |
| #[error("Received RAV does not match expected RAV")] |
Comment on lines
+48
to
+55
| #[cfg(any(test, feature = "test"))] | ||
| impl From<crate::receipt::SignedReceipt> | ||
| for ReceiptWithState<Checked, crate::receipt::SignedReceipt> | ||
| { | ||
| fn from(signed_receipt: crate::receipt::SignedReceipt) -> Self { | ||
| ReceiptWithState { | ||
| signed_receipt, | ||
| _state: Checked, |
| } | ||
| } | ||
|
|
||
| let receipts = receipts.into_iter().map(Into::into).collect::<Vec<_>>(); |
Contributor
There was a problem hiding this comment.
No big deal but here is one place I'd like to see what type it's being coerced to 😄
suchapalaver
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: