Skip to content

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Jan 23, 2025

EscrowHandler was supposed to keep track of the escrow balance and keep it under the maximum amount willing to lose. Managers are created to be one per Allocation, whereas the escrow balance is shared between all allocations for a given sender.
This was replaced by the Tracker in tap-agent, and we are removing now that methods since it doesn't fit.

  • Rename EscrowHandler to SignatureHandler
  • Remove subtract_escrow and get_available_escrow
  • Remove AwaitingReserve receipt state
  • Rename Reserved to Checked receipt state

@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12932543202

Details

  • 16 of 19 (84.21%) changed or added relevant lines in 3 files are covered.
  • 22 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.0%) to 81.505%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap_core/src/manager/adapters/signature.rs 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
tap_core/src/manager/context/memory.rs 22 81.31%
Totals Coverage Status
Change from base Build 12931811666: -2.0%
Covered Lines: 1040
Relevant Lines: 1276

💛 - Coveralls

Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/remove-escrow-state branch from 20cd582 to a321487 Compare January 23, 2025 14:11
@suchapalaver suchapalaver changed the title refactor!: remove unused escrow handler methods refactor: remove unused escrow handler methods Jan 23, 2025
@gusinacio gusinacio changed the title refactor: remove unused escrow handler methods refactor!: remove unused escrow handler methods Jan 23, 2025
@gusinacio gusinacio merged commit e5511ff into main Jan 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants