refactor!: make manager generic over rav #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/manager-generic-for-rav
branch
from
9bc39bb to
e2889e4
Compare
Pull Request Test Coverage Report for Build 12936846271Details
💛 - Coveralls |
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/manager-generic-for-rav
branch
from
872b82f to
0726209
Compare
|
|
||
| impl WithValueAndTimestamp for ReceiptAggregateVoucher { | ||
| fn value(&self) -> u128 { | ||
| self.valueAggregate |
Contributor
There was a problem hiding this comment.
Suggested change
| self.valueAggregate | |
| self.valueAggregate |
Is this Solidity?
suchapalaver
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregatetrait to be implemented in Ravs