feat: add horizon types to tap_graph #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusinacio
force-pushed
the
gustavo/tap-graph-v2
branch
from
19f140c to
f323ed7
Compare
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/tap-graph-v2
branch
from
f323ed7 to
b7bd0da
Compare
Pull Request Test Coverage Report for Build 13020749107Details
💛 - Coveralls |
Comment on lines
+25
to
+47
| sol! { | ||
| /// Holds information needed for promise of payment signed with ECDSA | ||
| /// | ||
| /// We use camelCase for field names to match the Ethereum ABI encoding | ||
| #[derive(Debug, Serialize, Deserialize, Eq, PartialEq)] | ||
| struct ReceiptAggregateVoucher { | ||
| /// Unique allocation id this RAV belongs to | ||
| address allocationId; | ||
| // The address of the payer the RAV was issued by | ||
| address payer; | ||
| // The address of the data service the RAV was issued to | ||
| address dataService; | ||
| // The address of the service provider the RAV was issued to | ||
| address serviceProvider; | ||
| // The RAV timestamp, indicating the latest TAP Receipt in the RAV | ||
| uint64 timestampNs; | ||
| // Total amount owed to the service provider since the beginning of the | ||
| // payer-service provider relationship, including all debt that is already paid for. | ||
| uint128 valueAggregate; | ||
| // Arbitrary metadata to extend functionality if a data service requires it | ||
| bytes metadata; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
@gusinacio could you just explain why this needs to be abi encoded, presumably because this is interacting with a contract. Would be great to be able to make the link here. Can also do it in a subsequent PR if you wanna explain here quickly 👍
Contributor
Author
There was a problem hiding this comment.
Definition of encodeType.
https://eips.ethereum.org/EIPS/eip-712#definition-of-domainseparator
https://docs.rs/alloy/latest/alloy/sol_types/macro.sol.html
sol macro generates the encodeType for EIP712, it doesn't use serde and at the time, there was no way to "rename camelCase" like we do in serde
Contributor
Author
There was a problem hiding this comment.
it looks like it still doesn't have that alloy-rs/core#570
suchapalaver
approved these changes
Jan 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2feature flag (unstable for now)For now, handling both receipts is delegated to the lib user but serialization might be added in a future PR.