refactor(eip712): simplify message unique id #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Livesey <[email protected]>
suchapalaver
force-pushed
the
suchapalaver/refactor-tap-receipt-unique-hash
branch
from
158d854 to
57a01d9
Compare
Pull Request Test Coverage Report for Build 14919843802Details
💛 - Coveralls |
neithanmo
approved these changes
May 9, 2025
Contributor
|
perfect! cleaner indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just reading the report and @severiano-sisneros 's notes more carefully and this seems like a more elegant solution to #291, without pulling in what was essentially a bit of test infra into the broader system. So this PR reverts much of that one. Note the test from #291 is still passing though!