Skip to content

fix(tap_core): remove need to allow deprecated APIs #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(tap_core): remove need to allow deprecated APIs #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tap_core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ rand.workspace = true
tap_eip712_message.workspace = true
tap_graph = { workspace = true, optional = true }
tap_receipt.workspace = true
thegraph-core.workspace = true
thegraph-core = { workspace = true, features = ["alloy-signer-mnemonic"] }
thiserror.workspace = true
tokio.workspace = true

Expand Down
9 changes: 3 additions & 6 deletions tap_core/tests/rav_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ use tap_core::{
tap_eip712_domain,
};
use tap_graph::{Receipt, ReceiptAggregateVoucher};
#[allow(deprecated)]
use thegraph_core::alloy::primitives::{Address, Signature};
use thegraph_core::alloy::{
dyn_abi::Eip712Domain,
primitives::{Address, Signature},
signers::local::{coins_bip39::English, MnemonicBuilder, PrivateKeySigner},
};

Expand Down Expand Up @@ -86,8 +85,6 @@ fn check_for_rav_serialization(domain_separator: Eip712Domain) {
}"#;

serde_json::from_str::<Signature>(raw_sig).unwrap();
#[allow(deprecated)]
serde_json::from_str::<Signature>(raw_sig).unwrap();
}

#[rstest]
Expand Down Expand Up @@ -119,7 +116,7 @@ async fn rav_storage_adapter_test(domain_separator: Eip712Domain, context: InMem

context.update_last_rav(signed_rav.clone()).await.unwrap();

// Retreive rav
// Retrieve rav
let retrieved_rav = context.last_rav().await;
assert!(retrieved_rav.unwrap().unwrap() == signed_rav);

Expand Down Expand Up @@ -148,7 +145,7 @@ async fn rav_storage_adapter_test(domain_separator: Eip712Domain, context: InMem
// Update the last rav
context.update_last_rav(signed_rav.clone()).await.unwrap();

// Retreive rav
// Retrieve rav
let retrieved_rav = context.last_rav().await;
assert!(retrieved_rav.unwrap().unwrap() == signed_rav);
}