feat, wip: support for optional #246
Conversation
semlanik
left a comment
semlanik
left a comment
There was a problem hiding this comment.
@pontaoski, thank you for your commit! I left few suggestions, but the feature looks useful overall.
| if(UNIX) | ||
| if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") | ||
| # using Clang | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror -Wno-pessimizing-move -Wno-mismatched-tags -Wno-unused-private-field -Wno-self-assign-overloaded") |
There was a problem hiding this comment.
Could you please move this fix to a separate patch set. I also suggest introducing something like 'QTPROTOBUF_DEVELOPER_BUILD' or 'QTPROTOBUF_WARNINGS_AS_ERROR' cache variable to opt-in this functionality.
There was a problem hiding this comment.
oops, didn't mean to commit this. was a local workaround for the wall werror failing to build on my machine.
sowelipililimute
force-pushed
the
work/janb/optiona
branch
3 times, most recently
from
061523d to
1c7a062
Compare
|
something i'm not too sure on is how to go about making it so that the constructors only default to true if the value is initialised in said constructors. currently all has_ values default to true even if the constructor doesn't initialise them. |
Sorry for the dreadful delay in response, but I'm not sure what has_ values you are talking about. |
this MR adds currently, the my problem is "how do i make the has_x fields only get set to true during construction if the corresponding argument for x in the constructor is set" |
sowelipililimute
force-pushed
the
work/janb/optiona
branch
from
1c7a062 to
922ed2c
Compare
2 participants
#244