Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Jul 15, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-7153

Description Of Changes

release 브랜치에서 테스트 완료하였습니다

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee requested review from bang9 and Copilot and removed request for Copilot July 15, 2025 01:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.49%. Comparing base (a614f97) to head (c3f8d1b).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #249    +/-   ##
========================================
  Coverage   11.49%   11.49%            
========================================
  Files         358      358            
  Lines        8490     8490            
  Branches     2395     2258   -137     
========================================
  Hits          976      976            
- Misses       7439     7513    +74     
+ Partials       75        1    -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances how the GitHub Actions workflow handles the version input in publish-package.yml for improved security and consistency.

  • Export the version into an environment variable for the validation script
  • Refactor branch name comparison and shorten the failure message
  • Use an env var for the lerna version command and quote the PR number in the approval step
Comments suppressed due to low confidence (2)

.github/workflows/publish-package.yml:66

  • PR_NUMBER is sourced from env.PR_NUMBER which isn’t defined in this step. This will result in an empty PR number when running gh pr review. Consider setting the PR number as an output in the validation step (e.g., using core.setOutput) and then referencing it here via steps.<step_id>.outputs.PR_NUMBER.
          PR_NUMBER: ${{ env.PR_NUMBER }}

.github/workflows/publish-package.yml:36

  • [nitpick] The error message uses a non-ASCII '≠' symbol which may not render reliably in all logs. Consider using a clear ASCII message such as Current branch ${currentBranch} does not match release/${version} for better readability.
               core.setFailed(`Branch ${currentBranch} ≠ release/${version}`);

@OnestarLee OnestarLee requested review from bang9 and removed request for bang9 July 15, 2025 01:18
@OnestarLee OnestarLee added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit a99ff44 Jul 15, 2025
7 checks passed
@OnestarLee OnestarLee deleted the fix/internal-security branch July 15, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants