Skip to content

chore: improve version handling in publish-package.yml for security #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OnestarLee merged 3 commits into from
Jul 15, 2025
Merged

chore: improve version handling in publish-package.yml for security #249

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddbf78d
chore: improve version handling in publish-package.yml for security
OnestarLee Jul 15, 2025
9e240f9
chore: improve error message for branch mismatch in publish-package.yml
OnestarLee Jul 15, 2025
c3f8d1b
chore: improve error message for branch mismatch in publish-package.yml
OnestarLee Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/publish-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@ jobs:
- uses: actions/setup-node@v4
- name: 'validation'
uses: actions/github-script@v7
env:
VERSION: ${{ github.event.inputs.version }}
with:
script: |
const version = process.env.VERSION;
const permission = await github.rest.repos.getCollaboratorPermissionLevel({
owner: context.repo.owner,
repo: context.repo.repo,
Expand All @@ -29,8 +32,8 @@ jobs:
core.setFailed(`User ${context.actor} does not have write or admin permissions to this repository.`);
}
const currentBranch = context.ref.replace('refs/heads/', '');
if (currentBranch !== `release/${{ github.event.inputs.version }}`) {
core.setFailed(`Current branch ${currentBranch} does not match release/${{ github.event.inputs.version }}`);
if (currentBranch !== `release/${version}`) {
core.setFailed(`Current branch ${currentBranch} does not match release/${version}`);
}
const pullRequests = await github.rest.pulls.list({
owner: context.repo.owner,
Expand All @@ -53,11 +56,13 @@ jobs:
- name: 'publish to npm'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VERSION: ${{ github.event.inputs.version }}
run: |
yarn lerna version ${{ github.event.inputs.version }} --yes
yarn lerna version "$VERSION" --yes
yarn lerna publish from-git --yes
- name: 'approve a pull request'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ env.PR_NUMBER }}
run: |
gh pr review ${{ env.PR_NUMBER }} --approve --body "approved by automation"
gh pr review "$PR_NUMBER" --approve --body "approved by automation"