Skip to content

[CLNP-6724] fix: allow string values for borderRadius in StyleSheet #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OnestarLee merged 2 commits into from
May 7, 2025
Merged

[CLNP-6724] fix: allow string values for borderRadius in StyleSheet #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8415fae
fix: allow string values for borderRadius in StyleSheet
OnestarLee May 7, 2025
3d02958
chore: update comment for ts-ignore in createStyleSheet
OnestarLee May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/uikit-react-native-foundation/src/styles/createStyleSheet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,15 @@ const SCALE_FACTOR_WITH_DIMENSION_VALUE = (
};

const DEFAULT_SCALE_FACTOR_WITH_NUMERIC_VALUE = (
val: NonNullable<AnimatableNumericValue | undefined>,
): NonNullable<AnimatableNumericValue | undefined> => {
val: NonNullable<AnimatableNumericValue | string | undefined>,
): NonNullable<AnimatableNumericValue | string | undefined> => {
return typeof val === 'number' ? DEFAULT_SCALE_FACTOR(val) : val;
};

const preProcessor: Partial<StylePreprocessor> = {
'fontSize': DEFAULT_SCALE_FACTOR,
'lineHeight': DEFAULT_SCALE_FACTOR,
//@ts-ignore : Ensure compatibility with all supported React Native versions
Copy link

Copilot AI May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider expanding the @ts-ignore comment to reference the relevant React Native version or commit for clarity and future maintainability.

Suggested change
//@ts-ignore : Ensure compatibility with all supported React Native versions
//@ts-ignore: Required for compatibility with React Native version >=0.65 due to changes in StyleSheet types. See https://github.com/facebook/react-native/commit/<commit-hash>.

Copilot uses AI. Check for mistakes.
'borderRadius': DEFAULT_SCALE_FACTOR_WITH_NUMERIC_VALUE,
'minWidth': SCALE_FACTOR_WITH_DIMENSION_VALUE,
'maxWidth': SCALE_FACTOR_WITH_DIMENSION_VALUE,
Expand Down